Complete clamped SwiGLU across expert paths - #5940
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 33bd241 |
FDecaYed
force-pushed
the
codex/clamped-swiglu
branch
from
July 23, 2026 15:53
33bd241 to
388eeb4
Compare
24 tasks
Contributor
Author
|
/ok to test 388eeb4 |
FDecaYed
force-pushed
the
codex/clamped-swiglu
branch
from
July 23, 2026 16:48
388eeb4 to
ec202a4
Compare
Contributor
Author
|
/ok to test ec202a4 |
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
FDecaYed
force-pushed
the
codex/clamped-swiglu
branch
from
August 10, 2026 11:28
6c0e3f6 to
0807774
Compare
deepakn94
approved these changes
Aug 10, 2026
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
Contributor
Author
|
/ok to test 4ba9d91 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/31685310896 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/31685597753 |
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete clamped SwiGLU across expert paths
Summary
Add clamped SwiGLU as one usable feature across the primitive, routed and
shared experts, token-weighted fallbacks, and the Transformer Engine grouped
MLP path.
Scope and non-goals
so optional
GroupedLinearkwargs are passed only when the installedinterface accepts them.
attention, or recipe changes.
Provenance
This local recut is reconstructed from the frozen
mainbaselinebb5647a9bdd0, not a replay. It references master #5795 and combines #5940and #5941 into one functional unit, including the completion fixes derived
from #4481 and #5130. Original clamped-SwiGLU and DSv4 integration credit:
@hxbai in #4481, #5130, and #5795.
Dependencies
None beyond the frozen baseline used for this local recut. This is a reusable
prerequisite outside the nine-PR DSv4-specific series.
Tests
unsupported-interface validation.
Publication
Publish in the first prerequisite round on then-current
main. This is not astacked-review PR.