fix(optimizer): checkpoint native FP32 parameters in mixed precision - #5930
Closed
FDecaYed wants to merge 1 commit into
Closed
fix(optimizer): checkpoint native FP32 parameters in mixed precision#5930FDecaYed wants to merge 1 commit into
FDecaYed wants to merge 1 commit into
Conversation
Keep optimizer-state ids aligned with model parameters when BF16/FP16 parameters are interleaved with parameters that remain natively FP32. Signed-off-by: Deyu Fu <Deyu.Foo@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 851d75d |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix sharded optimizer-state mapping when mixed-precision parameter groups interleave BF16/FP16 parameters with parameters that remain natively FP32. State ids now follow the inner optimizer order, while FP32 master copies are paired only with converted low-precision parameters.
This is a generic checkpointing correctness fix and is detached from the DSv4 stack. It does not depend on the parameter-marking PR; DSv4 call sites can consume both independently.
Provenance
Testing