Add VarlenLowLevelDataset, VarlenDataset, and MockVarlenDataset - #5909
Closed
ilml wants to merge 2 commits into
Closed
Add VarlenLowLevelDataset, VarlenDataset, and MockVarlenDataset#5909ilml wants to merge 2 commits into
ilml wants to merge 2 commits into
Conversation
This was referenced Jul 20, 2026
ilml
marked this pull request as ready for review
July 22, 2026 01:02
ilml
force-pushed
the
split/3386-09-varlen-datasets
branch
3 times, most recently
from
July 30, 2026 21:19
d2b043d to
3653065
Compare
ilml
force-pushed
the
split/3386-09-varlen-datasets
branch
2 times, most recently
from
August 6, 2026 16:44
e039174 to
6ec345e
Compare
ilml
force-pushed
the
split/3386-09-varlen-datasets
branch
2 times, most recently
from
August 10, 2026 22:09
856cee7 to
28eed6b
Compare
Split 8/10 from NVIDIA#3386 (sequence packing / THD E2E support). Adds the pure-Python schema detection (openai-messages, sharegpt, alpaca/dolly, pretraining-text) and message-normalization helpers for the varlen dataset, with CPU-only unit tests. Original changes by @xiaoyao0115 in NVIDIA#3386. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: ilml <tolong@nvidia.com>
Split 9/10 from NVIDIA#3386 (sequence packing / THD E2E support). Adds the variable-length packed (THD) dataset family: HF-hub/parquet/jsonl loading, THD __getitem__ with cu_seqlens, SBHD validation mode, and the mock variant, with unit tests. Also adds hybrid_context_parallel=False to the _make_config test helper (deviation from NVIDIA#3386: fixes a latent AttributeError in _calculate_padding_divisor with SimpleNamespace configs). Original changes by @xiaoyao0115 in NVIDIA#3386. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: ilml <tolong@nvidia.com>
6 tasks
Contributor
Author
|
/ok to test 28eed6b |
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the variable-length packed (THD) dataset family: HF-hub/parquet/jsonl loading, THD
__getitem__emittingcu_seqlens/original_seq_len/padded_seq_len, the SBHD validation mode, and the mock variant, with unit tests.Part 09/10 of splitting #3386 (Add E2E support for THD format; dev-branch PR #2924). Original changes by @xiaoyao0115 in #3386 — split into functionally self-contained PRs to ease review. Hard dependencies (must merge first): #5906, #5908.
Split series (#3386)
Branches are stacked linearly (each on the previous) so every PR shows a clean own-diff once its base is retargeted to the copy-pr-bot
pull-request/<parent>ref; until then the Files-changed view of a stacked PR includes its ancestors — its own change is the last commit.Stacked on #5907 (carries a copy of #5908's commit so the branch is self-sufficient; it drops out automatically when #5908 merges).
Review notes
hybrid_context_parallel=Falseto the_make_configtest helper — without it, six__getitem__tests crash with AttributeError because_calculate_padding_divisorreadsconfig.hybrid_context_parallelunguarded on a SimpleNamespace config.Issue tracking
Linked issue: Related to #3386
Contribution process
Pre-checks
🤖 Generated with Claude Code