ci: integrate nemo-ci-triage with linear issues management for gitlab failures - #5881
Merged
Merged
Conversation
- Introduced a new triage stage in the CI pipeline. - Added new variables for Linear issue reconciliation and reporting. - Updated functional tests to output summary and failure bucket files. - Modified Dockerfile to use a new commit for the triage component. - Enhanced test utilities to support Linear reporting and notifications. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Update functional test notification rules - Modified notification rules for smoke and functional tests to trigger for all pipelines, regardless of branch name or pipeline source. - Expanded the functional test scope to include weekly and release pipelines. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Refine CI configuration for Linear issue reconciliation and test notifications - Updated descriptions in the CI variables for clarity. - Modified notification rules to trigger for all functional test pipelines. - Added PYTHONPATH export to relevant scripts for improved module resolution. - Adjusted conditions for Linear reconciliation jobs to apply to all functional pipelines. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Configure Linear failure-ticket project Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Update MCORE_LINEAR_PROJECT variable value for clarity - Changed the value of MCORE_LINEAR_PROJECT from a specific identifier to a more descriptive name "MCore CI Testing" for improved readability and understanding in the CI configuration. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Enhance Slack integration for Linear issue reporting - Added functionality to post Linear action summaries to Slack, including tracking of opened, modified, and closed issues. - Updated CI configuration to include Slack output artifacts and context for follow-up notifications. - Enhanced test utilities to validate Slack notifications and ensure proper context is recorded for threaded replies. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Refactor Linear CI integration and introduce triage configuration - Removed deprecated MCORE_LINEAR_TEAM_KEY and MCORE_LINEAR_PROJECT variables from CI configuration. - Added NEMO_CI_TRIAGE_CONFIG variable to specify the new triage configuration file. - Updated CI scripts to utilize the new configuration for Linear status and reconciliation processes. - Introduced a new .gitlab/nemo-ci-triage.yml file to define project-specific settings for the triage module. - Enhanced test utilities to validate the new configuration and ensure proper integration with the Linear workflow. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Update triage CI script and remove deprecated functions - Replaced the Python script call in the triage CI configuration with a new command for improved integration. - Updated the Dockerfile to reflect a new commit for the triage component. - Removed deprecated `apply_linear_plan` function and related tests to streamline the codebase. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Update triage CI script commands for consistency - Modified triage CI script commands to use consistent naming conventions for improved readability. - Updated the Dockerfile to reflect a new commit hash for the triage component. Signed-off-by: Ajay Balasa <abalasa@nvidia.com> ci: Update triage CI script and Dockerfile for improved Slack integration - Replaced the Python script call in the triage CI configuration with a new command for posting Linear action summaries to Slack. - Updated the Dockerfile to reflect a new commit hash for the triage component. - Removed deprecated functions from the Linear CI integration to streamline the codebase. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
- Updated notification rules in the CI configuration to trigger based on specific branch names and pipeline sources for unit and functional tests. - Adjusted conditions to ensure notifications are sent only for scheduled pipelines or specific branches, enhancing the clarity and relevance of test notifications. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
July 20, 2026 01:33
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
- Included 'env' command in the unit and functional test scripts to log environment variables during execution. - Updated Dockerfile to reflect a new commit hash for the triage component. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
balasaajay
changed the title
- Refined notification rules for unit and functional tests to trigger based on specific conditions, enhancing clarity and relevance. - Adjusted rules to ensure notifications are sent for merged results and specific test conditions. - Updated Dockerfile to reflect a new commit hash for the triage component. - Enhanced test utilities to validate notification rules and ensure comprehensive coverage of enabled test runs. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
- Updated notification rules in the CI configuration for unit and functional tests to trigger based on specific pipeline sources and branch names, enhancing clarity and relevance. - Adjusted conditions to ensure notifications are sent for scheduled pipelines and specific branches, improving the accuracy of test notifications. - Enhanced test utilities to validate the updated notification rules. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
Member
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Phlip79
approved these changes
Jul 20, 2026
Phlip79
left a comment
Phlip79
left a comment
Member
There was a problem hiding this comment.
Looking forward to seeing this deployed!
thomasdhc
approved these changes
Jul 20, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29774508375 |
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
… failures (NVIDIA#5881) Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
svcnvidia-nemo-ci
pushed a commit
to dimapihtar/Megatron-LM
that referenced
this pull request
Aug 4, 2026
… failures (NVIDIA#5881) Signed-off-by: Ajay Balasa <abalasa@nvidia.com> Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Integrate nemo-ci-triage into the internal Megatron-LM GitLab pipeline to:
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.