Skip to content

Log app_finish_time and app_train_loop_finish_time on early-exit path #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericharper merged 1 commit into from
Jul 21, 2026
Merged

Log app_finish_time and app_train_loop_finish_time on early-exit path #5864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions megatron/training/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4001,6 +4001,13 @@ def trace_handler(p):
if should_exit:
break

# Early-exit paths (exit-duration / exit-interval / signal handler) sys.exit()
# below before the normal-path logging, so record the train-loop finish time here.
if should_exit:
one_logger and one_logger.log_metrics(
{'app_train_loop_finish_time': one_logger_utils.get_timestamp_in_ms()}
)

# Destroy CUDA Graphs.
if args.cuda_graph_impl == "transformer_engine" and cuda_graph_helper.graphs_created():
cuda_graph_helper.delete_cuda_graphs()
Expand Down Expand Up @@ -4048,6 +4055,9 @@ def trace_handler(p):
for buf in model_module.buffers + model_module.expert_parallel_buffers:
if getattr(buf, 'nccl_mem_pool', None) is not None:
nccl_allocator.deregister_mem_pool(buf.nccl_mem_pool, buf.data_parallel_group)
one_logger and one_logger.log_metrics(
{'app_finish_time': one_logger_utils.get_timestamp_in_ms()}
)
wandb_writer = get_wandb_writer()
if wandb_writer:
wandb_writer.finish()
Expand Down
Loading