Skip to content

Add disaggregated KV transfer backends - #5861

Merged
wdykas merged 5 commits into
NVIDIA:mainfrom
nvcsathe:disagg-kv-transfer
Jul 30, 2026
Merged

wdykas merged 5 commits into
NVIDIA:mainfrom
nvcsathe:disagg-kv-transfer

Conversation

@nvcsathe

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Adds common KV transfer backend API for disagg, with NCCL and NIXL as the supported backends

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

Co-authored-by: Will Dykas <wdykas@nvidia.com>
Signed-off-by: Chaitra Sathe <csathe@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@wdykas

wdykas commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

/claude review

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread megatron/core/inference/disaggregation/transfer_backends/nixl.py
@wdykas
wdykas marked this pull request as ready for review July 22, 2026 14:18
@wdykas
wdykas requested review from a team as code owners July 22, 2026 14:18
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team July 22, 2026 14:19
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-customer Waiting on the original author to respond label Jul 22, 2026
Comment thread megatron/core/inference/disaggregation/ssm_reshard.py
Signed-off-by: Will Dykas <wdykas@nvidia.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Jul 28, 2026
@wdykas

wdykas commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

/ok to test be0c56f

Signed-off-by: Will Dykas <wdykas@nvidia.com>
@wdykas

wdykas commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

/ok to test 5359038

@tdene

tdene commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

/ok to test b8f6914

@wdykas

wdykas commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

/ok to test 5ea4378

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30501207924

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30502505119

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30502653169

Merged via the queue into NVIDIA:main with commit 77c8772 Jul 30, 2026
87 of 88 checks passed
@wdykas
wdykas deleted the disagg-kv-transfer branch July 30, 2026 04:31
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Signed-off-by: Chaitra Sathe <csathe@nvidia.com>
Signed-off-by: Will Dykas <wdykas@nvidia.com>
Co-authored-by: Will Dykas <wdykas@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>

This branch was previously deployed

2 inactive deployments
public — 5ea43782 Deployed Jul 29, 2026 by copy-pr-bot[bot] via finalize / publish-docs #4924
test — 5ea43782 Deployed Jul 29, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants