Test mFSDP v2 overlap with default and symmetric memory - #5859
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
31641d3 to
87b36e0
Compare
|
/ok to test f0bcac2 |
|
/ok to test 8470c815a54f1951b405c4b6bca8056e807b7a7d |
|
/ok to test 8470c81 |
Use DeviceType.CUDA and DeviceType.CPU instead of stringly-typed device_type.name comparisons in the mfsdp_v2 profiler helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
949a9df to
85178ba
Compare
|
/claude fix |
Signed-off-by: svcnvidia-nemo-ci <svcnvidia-nemo-ci@nvidia.com>
|
🛠️ Claude fix commit
What changed Files changed by Claude
Why DCO Sanitized and posted by |
|
/ok to test f9876cf |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29837017618 |
|
✅ Claude fix CI passed after attempt 1. View exact-SHA CI. |
What changed
test_overlaps_communication_and_computeso it runs both the existing default collective path and the symmetric-memory path.device_ideager init, and explicitly warm the zero-CTA subgroup before constructing theDeviceMesh.collect_linked_kernels, so all-gather, reduce-scatter, and GEMM kernels are found without depending on device-side kernel names.activity_type, so zero-CTA all-gather copy-engineMemcpyevents are intentionally excluded.dim=16384workload.Why
The overlap test should cover symmetric-memory mFSDP behavior in addition to the default path. The symmetric-memory zero-CTA all-gather is copy-engine work rather than an SM-launched NCCL kernel, and GEMM kernel names vary across GPU architectures, so profiler attribution by linked CPU parent operation is more robust than matching device-side kernel names directly.
Impact
Test-only change. There is no production-code behavior change.
Related to #5655.
Validation
uv run --no-sync isort tests/unit_tests/distributed/mfsdp_v2/profiler_utils.py tests/unit_tests/distributed/mfsdp_v2/test_fully_shard.pyuv run --no-sync python -m compileall tests/unit_tests/distributed/mfsdp_v2/profiler_utils.py tests/unit_tests/distributed/mfsdp_v2/test_fully_shard.pygit diff --checkuv run --no-sync python -m pytest --collect-only -q tests/unit_tests/distributed/mfsdp_v2/test_fully_shard.py::test_overlaps_communication_and_computeFull distributed CUDA execution is left to CI.