fix(modelopt): AUT-854 respect moe_router_dtype in ptq HF import - #5830
Closed
svcnemo-autobot wants to merge 2 commits into
Closed
fix(modelopt): AUT-854 respect moe_router_dtype in ptq HF import#5830svcnemo-autobot wants to merge 2 commits into
svcnemo-autobot wants to merge 2 commits into
Conversation
Signed-off-by: Jinhang Choi <jinhangc@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
July 15, 2026 16:05
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
Collaborator
Author
|
/ok to test 2daf9d0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Branched off PR #5810. The ModelOpt PTQ example downcasts the MoE router because the HF→Mcore conversion does not receive
moe_router_dtypefrom the model args.What changed
Pass
moe_router_dtypethrough toimport_mcore_gpt_from_hfwhen the importer supports it and the arg is set.Details
examples/post_training/modelopt/quantize.py— add a guardedimport_kwargs.update({"moe_router_dtype": args.moe_router_dtype}), mirroring the existingtrust_remote_codesignature-guard so older importers stay compatible.Tested
Content is byte-identical to PR #5810's head (
2daf9d0), whose DCO + check-approval are green. File is outside themegatron/core+tests/autoformat scope, so linting is unaffected. Watching CI on this fork PR.