Pair frozen FSDP backward hooks - #5710
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
wujingyue
force-pushed
the
nvtx-frozen-backward
branch
from
July 8, 2026 17:02
487ddcb to
47b4f3e
Compare
wujingyue
marked this pull request as ready for review
July 8, 2026 17:02
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
wujingyue
force-pushed
the
nvtx-frozen-backward
branch
from
July 8, 2026 21:59
47b4f3e to
6af8ca6
Compare
shjwudp
approved these changes
Jul 14, 2026
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
deepakn94
approved these changes
Jul 14, 2026
Phlip79
approved these changes
Jul 15, 2026
svcnvidia-nemo-ci
added
Approved
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 15, 2026
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com> # Conflicts: # megatron/core/distributed/fsdp/src/megatron_fsdp/experimental/module.py
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29468459658 |
chochowski
pushed a commit
to chochowski/Megatron-LM
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com> Signed-off-by: mchochowski <mchochowski@nvidia.com>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
svcnvidia-nemo-ci
pushed a commit
to dimapihtar/Megatron-LM
that referenced
this pull request
Aug 4, 2026
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com> Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post_backward()runs afterpre_backward().mfsdp_v2unit-test bucket, where the experimental FSDP v2 fixture lives.Validation
python -m py_compile megatron/core/distributed/fsdp/src/megatron_fsdp/experimental/module.py tests/unit_tests/distributed/mfsdp_v2/test_annotation.pygit diff origin/main...HEAD --check