Skip to content

Clarify NVIDIA email signing guidance #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wujingyue merged 1 commit into from
Jul 16, 2026
+6 −1
Merged

Clarify NVIDIA email signing guidance #5699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ skill keyword — infer it from the artifact you read.

- All PRs must be created as **drafts**. Use `gh pr create --draft` or the GitHub UI draft option.
- Never push branches directly to `https://github.com/NVIDIA/Megatron-LM`. You must push your branch to a personal fork (e.g. `https://github.com/<your-username>/Megatron-LM`), then open a PR from the fork's branch against `NVIDIA/Megatron-LM`.
- Commit PR changes with both `-s` and `-S`: `-s` adds the required `Signed-off-by` trailer, and `-S` signs the commit so copy-pr-bot and `/ok to test` can verify the pushed commit without manually specifying the SHA.
- Commit PR changes with both `-s` and `-S`: `-s` adds the required
`Signed-off-by` trailer, and `-S` signs the commit so copy-pr-bot and `/ok to
test` can verify the pushed commit without manually specifying the SHA.
Megatron Core engineers at NVIDIA should sign using their NVIDIA emails so they

@wujingyue wujingyue Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? I got kicked out from certain user groups because I had been signing with my personal email. But I'm not sure about the machinery behind.

are automatically added to the right user groups on the internal Slack
workspace.
- Read @docs/developer/contribute.md for the full contribution policy, including code style, commit message conventions, and issue guidelines.

### Code Quality
Expand Down
Loading