Skip to content

Add GPTModel to HybridModel migration guide - #5698

Merged
Phlip79 merged 6 commits into
NVIDIA:mainfrom
Phlip79:philip/gpt-hybrid-migration-guide
Jul 16, 2026
Merged

Add GPTModel to HybridModel migration guide#5698
Phlip79 merged 6 commits into
NVIDIA:mainfrom
Phlip79:philip/gpt-hybrid-migration-guide

Conversation

@Phlip79

@Phlip79 Phlip79 commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

@Phlip79
Add GPTModel to HybridModel migration guide
cec7bae 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Phlip79 added 3 commits July 8, 2026 15:24
@Phlip79
Align GPT-to-Hybrid skill with repository format
6203833 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
@Phlip79
Update guide
e2332c3 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
@Phlip79
Further update guide
35aa26d 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
@Phlip79
Phlip79 marked this pull request as ready for review July 9, 2026 00:27
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team July 9, 2026 00:27
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the docs-only documentation only (docs or docstrings) label Jul 9, 2026
@Phlip79

Phlip79 commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/ok to test

@Phlip79
Phlip79 requested review from guihong-nv and removed request for a team July 9, 2026 00:32
guihong-nv
guihong-nv reviewed Jul 13, 2026
View reviewed changes
Comment thread docs/user-guide/hybrid-model-migration.md
MoE is Hybrid layer 3. Expand attention-only lists with inactive entries for
the intervening MLP or MoE positions.

For pipeline parallelism, add `|` separators without changing the ordered layer

@guihong-nv guihong-nv Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may highlight the changes related to PP to a subsection. This is the major changes in terms of model parallelisms.

@Phlip79
Separate pipeline parallelism guidance
d68043c 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
@Phlip79

Phlip79 commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

/ok to test d68043c

@guihong-nv
guihong-nv self-requested a review July 15, 2026 18:48
guihong-nv
guihong-nv approved these changes Jul 15, 2026
View reviewed changes

@guihong-nv guihong-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phlip79
Phlip79 added this pull request to the merge queue Jul 15, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29443797398

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29447165108

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 15, 2026
@Phlip79

Phlip79 commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

/ok to test 2b60167

@Phlip79
Phlip79 enabled auto-merge July 16, 2026 00:20
@Phlip79
Phlip79 added this pull request to the merge queue Jul 16, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29461655911

Merged via the queue into NVIDIA:main with commit 802da56 Jul 16, 2026
47 checks passed
@Phlip79
Phlip79 deleted the philip/gpt-hybrid-migration-guide branch July 16, 2026 03:04
chochowski pushed a commit to chochowski/Megatron-LM that referenced this pull request Jul 20, 2026
@Phlip79 @chochowski
Add GPTModel to HybridModel migration guide (NVIDIA#5698)
c6c20d7 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
Signed-off-by: mchochowski <mchochowski@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@Phlip79 @terminator123
Add GPTModel to HybridModel migration guide (NVIDIA#5698)
cf4e2cd 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
@Phlip79 @dimapihtar
Add GPTModel to HybridModel migration guide (NVIDIA#5698)
a2dc5ac 
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guihong-nv guihong-nv guihong-nv approved these changes

Assignees

No one assigned

Labels

docs-only documentation only (docs or docstrings)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Phlip79 @svcnvidia-nemo-ci @guihong-nv