-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[dev] moe(perf): Refactor CP layout - auto layout conversion #5664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
yuzhongw-nvidia
wants to merge
7
commits into
NVIDIA:dev
from
yuzhongw-nvidia:yuzhongw/refactor-cp-layout
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
868d929
refactor(cp): add partition-mode conversion package
yuzhongw-nvidia d60fe51
refactor(cp): add THD route tensor prebuild
yuzhongw-nvidia 9886c30
refactor(cp): wire fixed CP layout support
yuzhongw-nvidia 2dc50c2
test(cp): cover fixed partition-mode behavior
yuzhongw-nvidia 8b2cb45
fix(cp): keep stage-entry plumbing out of fixed layout
yuzhongw-nvidia 4bca670
refactor(cp): add auto partition-mode support
yuzhongw-nvidia 4b1f888
DEBUG-ONLY REMOVE BEFORE MERGE: test: add GDN MoE CP loss parity cove…
yuzhongw-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SUGGESTION Naming] Import order:
hybrid_layer_allocationsorts beforehybrid_layer_specsalphabetically, so isort will want this new import placed above thehybrid_layer_specsline. Per CLAUDE.md ("after editing imports … runuv run isorton those files"), please run isort here to fix ordering before merge.