Skip to content

Inference: Add profile endpoints to chat completions. - #5611

Merged
sidsingh-nvidia merged 1 commit into
NVIDIA:mainfrom
sidsingh-nvidia:siddharth/profile-endpoints
Jul 14, 2026
Merged

Inference: Add profile endpoints to chat completions. #5611
sidsingh-nvidia merged 1 commit into
NVIDIA:mainfrom
sidsingh-nvidia:siddharth/profile-endpoints

Conversation

@sidsingh-nvidia

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Add start_profile and stop_profile endpoints to inference. This enables the client to decide which subset of the workload gets traced via nsys. Helps trim down the size of nsys traces.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

Signed-off-by: Siddharth Singh <sidsingh@nvidia.com>
@sidsingh-nvidia
sidsingh-nvidia requested review from a team as code owners July 1, 2026 20:58
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft July 1, 2026 20:59
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@sidsingh-nvidia
sidsingh-nvidia marked this pull request as ready for review July 14, 2026 06:21
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team July 14, 2026 06:21
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made complexity: low labels Jul 14, 2026
@sidsingh-nvidia
sidsingh-nvidia added this pull request to the merge queue Jul 14, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29312762705

Merged via the queue into NVIDIA:main with commit eadbaa6 Jul 14, 2026
92 of 95 checks passed
@sidsingh-nvidia
sidsingh-nvidia deleted the siddharth/profile-endpoints branch July 14, 2026 08:30
chochowski pushed a commit to chochowski/Megatron-LM that referenced this pull request Jul 20, 2026
Signed-off-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: mchochowski <mchochowski@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Siddharth Singh <sidsingh@nvidia.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Signed-off-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants