[codex] Propagate SBHD padding masks across pipeline stages - #5544
Merged
xiaoyao0115 merged 1 commit intoAug 2, 2026
Merged
Conversation
xiaoyao0115
force-pushed
the
codex/propagate-sbhd-padding-mask
branch
from
June 30, 2026 08:03
2b06396 to
a423e3c
Compare
Contributor
Author
|
/ok to test a423e3c |
yaox12
approved these changes
Jul 27, 2026
xiaoyao0115
force-pushed
the
codex/propagate-sbhd-padding-mask
branch
from
July 27, 2026 07:32
a423e3c to
0668921
Compare
Contributor
Author
|
/ok to test 0668921 |
xiaoyao0115
force-pushed
the
codex/propagate-sbhd-padding-mask
branch
from
July 28, 2026 06:53
041689f to
5332138
Compare
Contributor
Author
|
/ok to test 5332138 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30518324343 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
xiaoyao0115
force-pushed
the
codex/propagate-sbhd-padding-mask
branch
from
July 30, 2026 06:21
37681aa to
226bbf8
Compare
Contributor
Author
|
/ok to test 226bbf8 |
xiaoyao0115
enabled auto-merge
July 30, 2026 06:25
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 30, 2026
Contributor
Author
|
/ok to test f7f921f |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30542908727 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30702635342 |
Signed-off-by: Tailai Ma <58548582+xiaoyao0115@users.noreply.github.com>
Contributor
Author
|
/ok to test 78ffb15 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30735666591 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This splits the SBHD validation padding-mask propagation fix out of #5535.
padding_maskfrom SBHD validation samples, separate from the LM loss mask.Why?
Prompt tokens can be loss-masked while still being valid model inputs, so the loss mask cannot identify physical padding. Intermediate pipeline stages also need physical padding metadata for their local layers.
Impact
Every pipeline stage receives the correct SBHD physical-padding mask without changing prompt-token participation or LM loss masking.
Validation
BASE_REF=dev CHECK_ONLY=true SKIP_DOCS=true bash tools/autoformat.shtests/unit_tests/data/test_varlen_dataset.py: 69 passed