fix(moe): exclude padding tokens from dropless HybridEP routing - #5515
Open
seonjinn wants to merge 6 commits into
Open
fix(moe): exclude padding tokens from dropless HybridEP routing#5515seonjinn wants to merge 6 commits into
seonjinn wants to merge 6 commits into
Conversation
Signed-off-by: Seonjin Na <sna@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
June 26, 2026 22:26
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
Signed-off-by: Seonjin Na <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exclude physical padding rows from MoE routing before dropless HybridEP dispatch.
This ports the routing-mask behavior already merged to
devin #5542 ontomain:flex+hybridepwith no expert or rank capacity factor;Why?
#6114 fixes padding-mask broadcasting for expert-bias token counts, but it does not remove physical padding rows from HybridEP dispatch. NeMo-RL sequence-packed THD workloads construct and pass this mask in NVIDIA-NeMo/RL#2964; MCore must consume it before dispatch to prevent padding rows from reaching experts.
After merging current
main, this PR drops its older changes that are now owned by #6114 and the current sequence-parallel mask-alignment paths. The final diff is limited to the router behavior and focused unit coverage.Validation
mainpy_compile, Black, isort, Ruff, andgit diff --checkpassedThe focused H100 run used the final router and test contents. The branch then merged the latest upstream
main; that upstream commit did not touch either changed file.Related