Repository navigation
Thread process groups through training checkpoint paths #5486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yashaswikarnati
merged 13 commits into
NVIDIA:main
from
yashaswikarnati:codex/pr5377-pg-threading
Jun 25, 2026
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
52348a0
Thread process groups through training checkpoint paths
yashaswikarnati c8f7199
Remove redundant MIMO optimizer comment
yashaswikarnati b45f91b
Address process group review comments
yashaswikarnati 51c4ed9
Thread RNG checkpoint and seed groups
yashaswikarnati 6874d28
Move RNG key prefix after checkpoint groups
yashaswikarnati 8f67657
Use DP CP fallback for checkpoint RNG state
yashaswikarnati 5e414fb
Use rank-local TP size for JIT warmup
yashaswikarnati 307af54
Thread expert DP group into checkpoint save
yashaswikarnati 04098c7
Use DP group for checkpoint RNG list indexing
yashaswikarnati 7e188cc
Thread seed groups through initialize
yashaswikarnati 6e3704f
Use threaded ranks for legacy checkpoint save gate
yashaswikarnati 1bdd7a9
Remove redundant training PGC comment
yashaswikarnati 2b23843
Add MIMO optimizer method docstrings
yashaswikarnati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the change at this line? why are we still using mpu groups here ?