Skip to content

chore: nightly sync main into dev (22_06_2026) - #5430

Merged
chtruong814 merged 45 commits into
devfrom
main2dev/22_06_2026
Jun 26, 2026
Merged

chore: nightly sync main into dev (22_06_2026)#5430
chtruong814 merged 45 commits into
devfrom
main2dev/22_06_2026

Conversation

@svcnvidia-nemo-ci

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Automated nightly sync of maindev for 22_06_2026.

Merge strategy

Started from origin/dev, ran git merge origin/main --no-edit, and resolved 16 conflicts surgically (no global -X theirs). The dev branch has a substantially diverged inference stack; conflicts were resolved to preserve dev features. Post-review exceptions are documented below: theoretical_memory_usage.py intentionally favors main's LatentMoE memory-accounting fix from #5145, and #5493 restores main's fused group MLP offload support from #5082.

Dependency triple & governance — kept dev's versions verbatim

  • pyproject.toml, uv.lock, docker/Dockerfile.ci.dev — identical to dev (dev's TE revision, emerging_optimizers v0.3.0, nvidia-resiliency-ext, PyPI mamba-ssm). No git-source reconciliation needed.
  • .github/CODEOWNERS — identical to dev (never modified).

Files taken from main (override list)

  • megatron/training/training.py — main's version (RL-inference import retargeted to megatron.core.inference.shards).
  • initialize.py, datasets/data_samplers.py, optimizer/layer_wise_optimizer.py — resolved to dev (already equal to dev; consistent with dev-based arguments.py).

Conflicts resolved toward dev (diverged inference / MLA / offload stacks)

multi_latent_attention.py, absorbed_mla.py, fine_grained_activation_offload.py, rope_utils.py, gpt_model.py, moe/experts.py, moe/router.py, transformer_config.py, checkpointing.py, pretrain_gpt.py, pretrain_hybrid.py, inference config.py / text_generation_controller.py / mamba_slot_allocator.py, and matching unit tests. arguments.py resolved to dev + the new --inference-shards arg.

Intentional main-over-dev follow-up

  • LatentMoE theoretical memory estimate (Fix LatentMoE theoretical memory estimate #5145) — favored main's fix in megatron/training/theoretical_memory_usage.py and restored its focused unit test in tests/unit_tests/training/test_weight_and_optimizer_memory.py. This intentionally replaces the old dev routed-expert formulas; main merge commit: 1bcb3b9e0b029c6109d8d32872645bd540052963.
  • Fused group MLP activation offload ([feat] Support fine-grained activation offloading in fused group mlp #5082, restored by fix: restore fused group MLP offload in main2dev sync #5493) — restored main's fused group MLP offload support across fine_grained_activation_offload.py, moe/experts.py, transformer_config.py, docs, and the matching offload tests. This intentionally replaces the older dev-only documentation/config/code paths for expert_fc1 / moe_act-only offload; main merge commit: 5c660c3b4a9d91e7ed32997b56cd6d333ed04bc5.

New main features brought in additively

  • megatron/core/inference/shards.py, shards_spec.py, tests/unit_tests/inference/test_inference_shards.py — the inference shard-spec API + --inference-shards arg (Disag MR1). Self-contained (only depend on mpu / HyperCommGrid / ProcessGroupCollection), wired through arguments.pyshards_spec.py.
  • Knowledge-distillation modules (megatron/training/distillation/*), megatron/rl/rl_profiling.py, FSDP experimental/*, MIMO runtime, and all cleanly-merged main changes.

Deferred (kept dev; needs human reconciliation)

The runtime integration from the 3 newest commits modifies dev files that have diverged reimplementations, so taking main would drop dev lines (guard violation). Deferred to keep dev's stack intact and CI green:

Deletions / restorations

  • .github/workflows/sync-skills.ymlremoved, matching main's intentional deletion (41dbab44a, ci: Remove sync skills workflow #5091). Dev's removal of multi-approval-bot.yml (ci: Remove multi-approval action from dev branch #3576) and the h100/{bert,t5}.yaml recipes is preserved.
  • megatron/rl/parallel_utils.pyrestored to dev. Main moved build_inference_pg_collection into shards.py; since the Disag refit refactor is deferred, dev's benchmark_refit.py / test_model_swap.py callers still need it. Both modules coexist (no broken imports).
  • tests/unit_tests/inference/engines/test_cg_admission_gating.pynot included (main-new test for the admission-gating path, which is deferred with dev's dynamic_engine.py).

Local validation

CI to follow via /ok to test.

tdene and others added 30 commits June 12, 2026 16:35
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: janEbert <janpabloe@nvidia.com>
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
Signed-off-by: Helen Ngo <helenn@nvidia.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Shijie Wang <jaywan@nvidia.com>
…izer) (#5333)

Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
#5360)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Deepak Narayanan <dnarayanan@nvidia.com>
… module globals (#5351)

Signed-off-by: ilml <tolong@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
…h space buffers (#5348)

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Co-authored-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: sraman <sraman@nvidia.com>
Signed-off-by: Jingyue Wu <wujingyue@gmail.com>
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Signed-off-by: Jingyue Wu <wujingyue@gmail.com>
Signed-off-by: Jingyue Wu <wujingyue@gmail.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
…5372)

Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@FDecaYed

Copy link
Copy Markdown
Contributor

/ok to test 213314b

@FDecaYed FDecaYed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see @Phlip79 fixed #5145 issue and #5493 is merged to fix missing #5082

approving

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

Superseded by today's nightly sync.

Signed-off-by: hongbinl <hongbinl@nvidia.com>
Signed-off-by: svcnvidia-nemo-ci <svc-nvidia-nemo-ci@nvidia.com>
@Phlip79
Phlip79 force-pushed the main2dev/22_06_2026 branch from 213314b to f6c77e7 Compare June 25, 2026 16:14
@Phlip79

Phlip79 commented Jun 25, 2026

Copy link
Copy Markdown
Member

/ok to test f6c77e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: high Run functional tests Run MBridge tests Attach this for testing this PR against MBridge main

Projects

None yet

Development

Successfully merging this pull request may close these issues.