Skip to content

Account for reasoning token stripping #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdene merged 1 commit into from
Jun 13, 2026
Merged

Account for reasoning token stripping #5313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...re/inference/text_generation_server/dynamic_text_gen_server/endpoints/chat_completions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,14 @@ def _replace_prefix_tokens(
from the previous generation (rather than the ones from the chat template application)."""

# Strip the EOS from the previous turn token ids if it exists
if previous_turn_token_ids[-1] == eos_token_id:
if previous_turn_token_ids and previous_turn_token_ids[-1] == eos_token_id:
previous_turn_token_ids = previous_turn_token_ids[:-1]

# Find the last EOS token id in the previous turn token ids
last_eos_token_id_index = len(retokeenized_previous_turn_token_ids) - 1
for i in reversed(range(len(retokeenized_previous_turn_token_ids))):
# Note that the current conversation stat may be shorter than the previous conversation state.
scan_len = min(len(retokeenized_previous_turn_token_ids), len(current_turn_token_ids))
for i in reversed(range(scan_len)):
if current_turn_token_ids[i] == eos_token_id:
last_eos_token_id_index = i
break
Expand Down
Loading