Skip to content

Fix crash due to tool call at sequence length #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdene merged 2 commits into from
Jun 13, 2026
Merged

Fix crash due to tool call at sequence length #5302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f9eec9
Fix crash due to tool call at sequence length
tdene Jun 11, 2026
dda6c06
Merge branch 'main' into tde/qwen3_param_guard
tdene Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion megatron/core/tokenizers/text/parsers/qwen3_coder_tool_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,10 @@ def _parse_xml_function_call(
parameters = function_call_str[end_index + 1 :]
param_dict = {}
for match_text in self.tool_call_parameter_regex.findall(parameters):
idx = match_text.index(">")
idx = match_text.find(">")
# Malformed parameter block with no name/value delimiter, e.g. truncated tool call.
if idx == -1:
continue
param_name = match_text[:idx]
param_value = str(match_text[idx + 1 :])
# Remove prefix and trailing \n
Expand Down
Loading