-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[Dev] Add Megatron-FSDP weight prefetch for full recompute #5175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhb8125
merged 13 commits into
NVIDIA:dev
from
lhb8125:codex/fsdp-recompute-prefetch-dev
Jun 16, 2026
+202
−49
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4c1013a
Optimize FSDP param bucket view setup
lhb8125 0d4016e
Prefetch recompute forward FSDP weights
lhb8125 079a5a3
chore: update FSDP copyright headers
lhb8125 bef8c71
Fix FSDP all-gather bucket release protection
lhb8125 fb698f4
Use config flag for recompute weight prefetch
lhb8125 6122a45
Validate FSDP recompute prefetch flag
lhb8125 3745d13
chore: update FSDP dev copyright headers
lhb8125 bcf9e8c
chore: fix FSDP recompute prefetch lint
lhb8125 c9b9e63
refactor: simplify FSDP recompute prefetch scheduling
lhb8125 8149d91
refactor: remove unused FSDP prefetch include-current option
lhb8125 94355a4
refactor: remove redundant FSDP current bucket list
lhb8125 a317180
Merge remote-tracking branch 'origin/dev' into codex/fsdp-recompute-p…
lhb8125 26c95cd
refactor: split FSDP bucket view cache flag
lhb8125 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I feel this code can be further simplified: