Skip to content

test(elastification): quarantine flaky test_gumbel_determinism as flaky_in_dev #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 1 commit into from
Jun 4, 2026
Merged

test(elastification): quarantine flaky test_gumbel_determinism as flaky_in_dev #5156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/unit_tests/elastification/test_hybrid_flex_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,17 @@ def test_emb_output_shape_matches_choice_count(self):
assert logits.numel() == len(config.emb_int_list)
assert choice in config.emb_int_list

@pytest.mark.flaky_in_dev
def test_gumbel_determinism(self):
"""Two routers at the same config + iteration + fwd_pass_count should
produce identical Gumbel-softmax samples."""
produce identical Gumbel-softmax samples.

Quarantined as flaky_in_dev (#5155): ``FlextronRouter.forward`` draws
``hard_sample`` from Python's un-seeded global ``random``, which is not
covered by the Gumbel ``torch.manual_seed``, so the two routers
intermittently disagree on the hard/soft branch and the bit-exact
``assert_close`` fails.
"""
config = _router_config()
config.curr_iteration = 0

Expand Down
Loading