Skip to content

test(release): skip golden comparison on intermediate resume windows #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 1 commit into from
May 28, 2026
Merged

test(release): skip golden comparison on intermediate resume windows #5040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/functional_tests/shell_test_utils/run_ci_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,25 @@ for i in $(seq 1 $N_REPEAT); do
echo $((TRAIN_ITERS / 2)) >$CHECKPOINT_SAVE_PATH/latest_checkpointed_iteration.txt
fi

# Release tests span multiple SLURM windows via checkpoint resume.
# Only compare against golden values once training has reached the
# configured exit interval; otherwise a partial-trajectory window
# would false-positive-fail the goldens check and block the
# orchestration's resumable retrigger.
if [[ "$TEST_TYPE" == "release" ]]; then
TRACKER_FILE="$CHECKPOINT_SAVE_PATH/latest_checkpointed_iteration.txt"
LATEST_ITER=0
if [[ -f "$TRACKER_FILE" ]]; then
LATEST_ITER=$(tr -d '[:space:]' <"$TRACKER_FILE" 2>/dev/null || echo 0)
[[ "$LATEST_ITER" =~ ^[0-9]+$ ]] || LATEST_ITER=0
fi
if (( LATEST_ITER < TRAIN_ITERS )); then
echo "Release intermediate window: latest checkpointed iter $LATEST_ITER < $TRAIN_ITERS; skipping golden-value comparison so the orchestration can resume."
continue
fi
echo "Release run reached iter $LATEST_ITER >= $TRAIN_ITERS; running golden-value comparison."
fi

if [[ ${RECORD_CHECKPOINTS} == "true" ]]; then
echo "Skipping Pytest during checkpoint recording."
SKIP_PYTEST=1
Expand Down
Loading