Skip to content

Add BlendedDataset fields to tests - #4981

Open
asolergi-nv wants to merge 3 commits into
NVIDIA:mainfrom
asolergi-nv:add-blend-to-tests
Open

Add BlendedDataset fields to tests #4981
asolergi-nv wants to merge 3 commits into
NVIDIA:mainfrom
asolergi-nv:add-blend-to-tests

Conversation

@asolergi-nv

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do ?

#4103 Introduced changes in the functions handling data inputs, but those changes didn't account for the BlendedDatasets. #4952 Fixed them & in this PR I'm including more checks to both tests/unit_tests/data/test_builder.py & tests/unit_tests/data/test_get_batch.py.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft May 26, 2026 09:02
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented May 26, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@asolergi-nv
asolergi-nv marked this pull request as ready for review May 26, 2026 09:03
@asolergi-nv

Copy link
Copy Markdown
Contributor Author

/claude review

Comment thread tests/unit_tests/data/test_get_batch.py

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition — the key-set assertions in test_builder.py and the provenance-key injection in test_get_batch.py look correct. One gap: create_hybrid_cp_data_iterator is missing the _add_provenance_keys call, so the hybrid CP test path doesn't exercise the cardinality contract. See inline comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants