Skip to content

Fix NameError in is_flashinfer_min_version when check_equality=False #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guihong-nv merged 1 commit into from
Jun 26, 2026
Merged

Fix NameError in is_flashinfer_min_version when check_equality=False #4961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion megatron/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ def is_flashinfer_min_version(version, check_equality=True):
return False
if check_equality:
return flashinfer_version >= PkgVersion(version)
return flashinver_version > PkgVersion(version)
return flashinfer_version > PkgVersion(version)


def accepts_parameter(func: Callable, name: str) -> bool:
Expand Down
18 changes: 18 additions & 0 deletions tests/unit_tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,24 @@ def test_divide_improperly():
util.divide(4, 5)


@pytest.mark.skipif(not util.HAVE_PACKAGING, reason="packaging is not installed")
@pytest.mark.parametrize("check_equality", [True, False])
def test_is_flashinfer_min_version(check_equality):
from packaging.version import Version as PkgVersion

with patch.object(util, "get_flashinfer_version", return_value=PkgVersion("0.6.5")):
# check_equality=False exercised the path that used to reference an
# undefined name and raise NameError instead of returning a bool.
assert util.is_flashinfer_min_version("0.6.4", check_equality=check_equality) is True
assert util.is_flashinfer_min_version("0.7.0", check_equality=check_equality) is False
assert (
util.is_flashinfer_min_version("0.6.5", check_equality=check_equality) is check_equality
)

with patch.object(util, "get_flashinfer_version", return_value=None):
assert util.is_flashinfer_min_version("0.6.4", check_equality=check_equality) is False


def test_experimental_cls_init():
with patch.object(config, 'ENABLE_EXPERIMENTAL', True):
# Check that initialization works
Expand Down
Loading