Fix build_mlp() missing name kwarg in custom-pg test - #4954
Draft
factnn wants to merge 2 commits into
Draft
Conversation
ko3n1g
reviewed
May 26, 2026
ko3n1g
left a comment
ko3n1g
left a comment
Contributor
There was a problem hiding this comment.
@factnn thanks for the contribution! could you also revert ko3n1g@741ae4e with this PR?
factnn
force-pushed
the
fix/build-mlp-accept-name-kwarg
branch
2 times, most recently
from
May 27, 2026 06:26
9290f42 to
d97717c
Compare
Contributor
Author
|
Done — rebased on latest main and removed the |
Contributor
Author
|
@ko3n1g Hi there, I've reverted the flaky marker as you requested. Let me know if you need anything else. |
Contributor
Author
|
@ko3n1g Hi, just checking in — the flaky marker has been reverted as you requested. Is there anything else needed? Thanks! |
factnn
force-pushed
the
fix/build-mlp-accept-name-kwarg
branch
from
June 17, 2026 10:56
daee661 to
cf6f3b4
Compare
transformer_layer.py now passes name= to submodules.mlp() (added in NVIDIA#4358), but the test helper build_mlp() did not accept it, causing TypeError in all test_transformer_block_custom_pgs parametrizations. Add name=None parameter and suppress it with the other unused args. Fixes NVIDIA#4934
Now that the root cause (missing name kwarg) is fixed, remove the emporary flaky_in_dev quarantine added in 741ae4e.
factnn
force-pushed
the
fix/build-mlp-accept-name-kwarg
branch
from
June 17, 2026 11:08
cf6f3b4 to
6dd6c5f
Compare
Contributor
Author
|
@ko3n1g @NVIDIA/mcore-oncall Hi! This PR has been updated per ko3n1g's review (reverted the flaky marker as requested) and rebased onto latest main. Could someone take a look? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transformer_layer.pynow passesname=tosubmodules.mlp()(added in #4358), but the test helperbuild_mlp()intest_transformer_block_custom_pgs.pydid not accept it, causingTypeErrorin all 5 parametrizations.Changes
name=Noneparameter tobuild_mlp()and suppress it alongside other unused args.Fixes #4934