Skip to content

[Dev] Remove duplicated bias_act_func from main to dev sync - #4927

Merged
yaox12 merged 1 commit into
NVIDIA:devfrom
yaox12:xiny/remove_duplicated_bias_act_func
May 22, 2026
Merged

[Dev] Remove duplicated bias_act_func from main to dev sync#4927
yaox12 merged 1 commit into
NVIDIA:devfrom
yaox12:xiny/remove_duplicated_bias_act_func

Conversation

@yaox12

@yaox12 yaox12 commented May 22, 2026

Copy link
Copy Markdown
Member
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do ?

This should be some garbage from main to dev sync.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12
yaox12 requested review from a team as code owners May 22, 2026 06:37
@copy-pr-bot

copy-pr-bot Bot commented May 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12

yaox12 commented May 22, 2026

Copy link
Copy Markdown
Member Author

/ok to test c39e735

@yaox12 yaox12 changed the title [Dev] Remove duplicated bias_act_func [Dev] Remove duplicated bias_act_func from main to dev sync May 22, 2026
@yaox12
yaox12 enabled auto-merge May 22, 2026 07:23
@yaox12
yaox12 added this pull request to the merge queue May 22, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26277240990

Merged via the queue into NVIDIA:dev with commit 56481b0 May 22, 2026
66 of 67 checks passed
@yaox12
yaox12 deleted the xiny/remove_duplicated_bias_act_func branch May 22, 2026 09:35
HaochenYuan pushed a commit to HaochenYuan/Megatron-LM that referenced this pull request Jun 12, 2026
…#4927)

Signed-off-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: HaochenYuan <haocheny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants