Bs invar moe - #4871
Merged
Merged
Conversation
svcnvidia-nemo-ci
marked this pull request as draft
May 19, 2026 16:34
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
Contributor
Author
|
/ok to test 7b69ea9 |
Contributor
Author
|
/ok to test d7ac4cd |
wdykas
force-pushed
the
bs-invar-moe
branch
5 times, most recently
from
May 21, 2026 13:25
ddb7bc6 to
cb7010e
Compare
wdykas
marked this pull request as ready for review
May 21, 2026 13:30
Contributor
Author
|
/ok to test 706d416 |
Contributor
Author
|
/ok to test 65758f0 |
santhnm2
approved these changes
Jul 29, 2026
jaredcasper
approved these changes
Jul 29, 2026
kvareddy
approved these changes
Jul 30, 2026
Signed-off-by: root <root@nvl72053-T14.cm.cluster>
wdykas
enabled auto-merge
July 30, 2026 12:51
Contributor
Author
|
/ok to test 7ee540d |
Signed-off-by: root <root@nvl72053-T14.cm.cluster>
Contributor
Author
|
/ok to test ad2fcaf |
Contributor
Author
|
/ok to test 7aee3eb |
Signed-off-by: root <root@nvl72053-T14.cm.cluster>
Contributor
Author
|
/ok to test 8e5e1f5 |
Signed-off-by: root <root@nvl72053-T14.cm.cluster>
Contributor
Author
|
/ok to test 1a48fcb |
Signed-off-by: root <root@nvl72151-T17.cm.cluster>
Contributor
Author
|
/ok to test 641d239 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30648069620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Makes nemotron batch invariant. Note that this has a huge diff but almost half of that diff is just unit tests.
⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.