Skip to content

[fix] Release MTP assertion when EP overlap with PP=1 #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericharper merged 3 commits into from
May 27, 2026
Merged

[fix] Release MTP assertion when EP overlap with PP=1 #4796

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fed11f
release assertion
Wohox May 14, 2026
b05b262
Merge branch 'main' into pingtian/release_pp1_mtp_ep_overlap_assertio…
Wohox May 20, 2026
f8d99b9
Merge branch 'main' into pingtian/release_pp1_mtp_ep_overlap_assertio…
Wohox May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions megatron/core/transformer/transformer_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2426,11 +2426,6 @@ def _scope_to_str(s):
assert (
self.mtp_num_layers is None or self.mtp_num_layers == 1
), 'MTP layernum only supports 1 when enabling overlap_moe_expert_parallel_comm.'
if self.mtp_num_layers == 1:
assert self.pipeline_model_parallel_size > 1, (
'Pipeline model parallel size must be larger than 1 '
'when enabling overlap_moe_expert_parallel_comm with MTP layer.'
)

if self.cuda_graph_impl != "none":
if self.cuda_graph_impl == "transformer_engine":
Expand Down
Loading