chore: nightly sync main into dev (12_05_2026) - #4767
Closed
svcnvidia-nemo-ci wants to merge 19 commits into
Closed
Conversation
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…al tests` (#4730) Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com> Co-authored-by: Cory Ye <44509866+cspades@users.noreply.github.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com>
Signed-off-by: Ajay Balasa <abalasa@nvidia.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Tuomas Rintamaki <trintamaki@nvidia.com> Co-authored-by: Tyler Poon <tylerpoon@gmail.com> Co-authored-by: Collin McCarthy <cmccarthy@nvidia.com> Co-authored-by: Matthieu Le <matthieul@nvidia.com> Co-authored-by: Piotr Zelasko <pzelasko@nvidia.com> Co-authored-by: Ehsan Hosseini Asl <ehosseiniasl@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
/ok to test 4e241c8 |
svcnvidia-nemo-ci
force-pushed
the
main2dev/12_05_2026
branch
from
May 12, 2026 22:56
9fc09b1 to
b408019
Compare
Contributor
Author
|
/ok to test b408019 |
svcnvidia-nemo-ci
force-pushed
the
main2dev/12_05_2026
branch
from
May 13, 2026 00:29
b408019 to
fb8317b
Compare
Contributor
Author
|
/ok to test fb8317b |
Contributor
Author
|
Superseded by today's nightly sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly main → dev sync bringing 17 commits from
mainintodev.Python-only line-change stats: Python lines: +3923 / -496 across 58 files
Files Taken Wholesale
These files were kept from one side because no surgical reconciliation was needed.
pyproject.toml,uv.lock,docker/Dockerfile.ci.dev— preserved perthe merge policy (dev has
fast-hadamard-transform, dev-pinned TE rev, omegaconfdependencies). No new git sources in main vs. dev's
[tool.uv.sources]neededporting.
.github/CODEOWNERS— intentionally divergent from main; nevermodified.
megatron/training/training.py,initialize.py,utils.py,datasets/data_samplers.py,core/optimizer/layer_wise_optimizer.py— no recentmain commits touched these files. Dev's evolution (e.g.
args.hybrid_context_parallel→
args.dynamic_context_parallelrename inc3dbea746) is preserved.Surgical Conflict Resolutions
git merge origin/main -X theirs --no-editleft these "Frankenstein" hybrids thatrequired manual reconciliation:
megatron/core/extensions/transformer_engine.py— restored dev'sTEFusedDenseMLPclass (Dense+Grouped GEMM fusion on SM100+, ~184 lines)that
-X theirsdropped when accepting main'sTEFusedMLP.as_mlp_submoduleaddition. Both additions now coexist.
megatron/core/models/gpt/gpt_layer_specs.py— three repairs:HyperConnectionTransformerLayerimport (used at L362, L489, L791).dense_grouped_gemm: bool = Falseparameter onget_mlp_module_spec_for_backend(callers inget_gpt_layer_with_transformer_engine_specpass it on L243).
dense_grouped_gemmbranch using main's new.as_mlp_submoduleclassmethod pattern (
not_none(TEFusedDenseMLP).as_mlp_submodule).megatron/core/models/gpt/experimental_attention_variant_module_specs.py—restored
HyperConnectionTransformerLayerimport (used at L304).megatron/core/transformer/moe/moe_layer.py— restoredinput_ids: Optional[torch.Tensor] = Noneparameter onMoELayer.forward;the body references
input_idsat L702 (self.route(... input_ids)).megatron/core/transformer/transformer_layer.py— four repairs:mlp_hyper_connectionfield onTransformerLayerSubmodules(used by
HyperConnectionTransformerLayerat L1531-L1604, L1749, L1872).**moe_kwargstotensor_parallel.checkpoint(functools.partial(apply_module(self.mlp)...)).**moe_kwargsto directapply_module(self.mlp)(...)call.input_ids=input_idsonMoETransformerLayer's router_outputs call.tests/unit_tests/transformer/moe/test_routers.py— restored imports ofTopKRouterandget_default_pg_collection(used at L621-L681, L620+L657respectively). Without these the suite fails with
NameError: name 'TopKRouter' is not defined(the failure that closed theprior bot run).
tests/unit_tests/transformer/moe/test_token_dispatcher.py— restoredMoETokenDispatcherimport (used at L37 for_NestedAttrTestDispatcher).Files Kept from Main (Conflict Resolution Verified)
megatron/training/config/container.py— main's lazy-import ofomegaconf(PR Guard omegaconf imports #4685 "Guard omegaconf imports") was the correct resolution; dev's
unconditional
from omegaconf import OmegaConfwas the regression main fixed.pretrain_vlm.py— kept main's import set (mpunot used in file;get_submodulesused at L186).Files Deleted in Dev (Not Restored)
tests/test_utils/recipes/h100/bert.yaml,tests/test_utils/recipes/h100/t5.yaml— both intentionally deleted on dev (commit
40d30942d: "fix: remove filesthat dev intentionally deleted"). Nothing in the merged tree references them.
.github/workflows/multi-approval-bot.yml— intentionally deleted on dev(PR ci: Remove multi-approval action from dev branch #3576). Dev's version respected.
Formatting
black --config pyproject.tomlclean on all 58 changed Python filesisortclean (applied toexamples/multimodal/radio/radio_g.py)Test plan
🤖 Generated with Claude Code