Skip to content

cp: build: widen flashinfer-python pin to <0.7.0 (#4700) into dev - #4760

Merged
chtruong814 merged 1 commit into
NVIDIA:devfrom
chtruong814:chtruong/cp-flash-infer
May 12, 2026
Merged

cp: build: widen flashinfer-python pin to <0.7.0 (#4700) into dev#4760
chtruong814 merged 1 commit into
NVIDIA:devfrom
chtruong814:chtruong/cp-flash-infer

Conversation

@chtruong814

Copy link
Copy Markdown
Contributor

What does this PR do ?

cp: build: widen flashinfer-python pin to <0.7.0 (#4700) into dev

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
chtruong814 requested a review from a team as a code owner May 12, 2026 17:19
@chtruong814

Copy link
Copy Markdown
Contributor Author

/ok to test 1f70419

@chtruong814
chtruong814 added this pull request to the merge queue May 12, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25754804259

Merged via the queue into NVIDIA:dev with commit c55150a May 12, 2026
66 of 67 checks passed
@chtruong814
chtruong814 deleted the chtruong/cp-flash-infer branch May 12, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants