[training migration] Migrate GPT builder - #4741
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
TODO:
|
dd281b8 to
870f7fa
Compare
|
/claude review |
There was a problem hiding this comment.
Good PR — clean migration of the GPT builder following the established HybridModelBuilder pattern, with solid unit test coverage.
Two inline comments posted:
-
Bug — copy-paste error in
GPTModelConfig.__getattr__: BothAttributeErrormessages sayMambaModelConfiginstead ofGPTModelConfig. This will confuse anyone debugging an attribute lookup failure. -
Nit — missing trailing comma in
__init__.py__all__list on"GPTModelBuilder".
Everything else (config proxying, vocab padding, layer spec dispatch, MTP handling, pretrain_gpt.py integration, tests) looks correct.
Signed-off-by: Maanu Grover <maanug@nvidia.com>
This reverts commit bc2ea8f.
Signed-off-by: Maanu Grover <maanug@nvidia.com>
7fa1b62 to
511ba6e
Compare
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26784364022 |
What does this PR do ?
Follow-up to #4550 for GPT Model.
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.