Fix release tests: remove --global-batch-size conflicting with --step-batch-size-schedule - #4545
Merged
ko3n1g merged 1 commit intoApr 30, 2026
Conversation
…-batch-size-schedule These two args are mutually exclusive. The step-batch-size-schedule already defines the batch size ramp, so global-batch-size is redundant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ko3n1g
approved these changes
Apr 30, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25153672872 |
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
…-batch-size-schedule (NVIDIA#4545) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
…-batch-size-schedule (NVIDIA#4545) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
…-batch-size-schedule (NVIDIA#4545) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--global-batch-sizefrom 4 GPT 15B release test configs that also specify--step-batch-size-schedule, which are mutually exclusive argsgpt3_15b_8t_release,gpt3_15b_8t_release_sm,gpt3_15b_8t_release_gb200,gpt3_15b_8t_release_sm_gb200--step-batch-size-schedulealready defines the batch size ramp (0:384 200B:768 400B:1152), making--global-batch-sizeredundantTest plan
ValueError: Cannot specify both --step-batch-size-schedule and --global-batch-size🤖 Generated with Claude Code