Skip to content

Revert "ci: add base_sha to codecov/codecov-action upload step (#4445)" - #4526

Merged
chtruong814 merged 2 commits into
NVIDIA:mainfrom
chtruong814:chtruong/revert-4445
Apr 29, 2026
Merged

Revert "ci: add base_sha to codecov/codecov-action upload step (#4445)"#4526
chtruong814 merged 2 commits into
NVIDIA:mainfrom
chtruong814:chtruong/revert-4445

Conversation

@chtruong814

Copy link
Copy Markdown
Contributor

What does this PR do ?

Revert "ci: add base_sha to codecov/codecov-action upload step (#4445)"

As part of this Github issue, the merge of 4445 reverted this other PR.
https://www.githubstatus.com/incidents/zsg1lk7w13cf

#4420

Will re-apply 4445 separately

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

…A#4445)"

This reverts commit 9bb35a8.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
chtruong814 requested review from a team as code owners April 29, 2026 18:10
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 29, 2026 18:10
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Apr 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@chtruong814

Copy link
Copy Markdown
Contributor Author

Fast merging since this is a revert and re-applying a change that should not have been reverted due to the Github problem.

@chtruong814
chtruong814 merged commit 51ea07e into NVIDIA:main Apr 29, 2026
233 of 235 checks passed
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
…A#4445)" (NVIDIA#4526)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
…A#4445)" (NVIDIA#4526)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants