Skills for running unit tests and working with slurm - #4502
Merged
yashaswikarnati merged 2 commits intoApr 29, 2026
Merged
Conversation
svcnvidia-nemo-ci
marked this pull request as draft
April 28, 2026 18:59
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
ko3n1g
approved these changes
Apr 28, 2026
Phlip79
requested changes
Apr 28, 2026
Member
There was a problem hiding this comment.
skills/running-unit-tests-in-megatron-lm.md: has a lot of overlap with the existingskills/testsystem/SKILL.md. I think the best solution is to update the existing skill.skills/running-on-slurm.md: can you conform to the rest of the skills with the naming please? Also, can you just name itslurm?
Two new skills documenting how to run Megatron-LM unit tests and how to launch distributed training on a SLURM cluster. run-unit-tests covers environment setup with `uv sync --extra training --extra dev`, the fact that all unit tests initialize a torch distributed group and must be launched through `torch.distributed.run`, single-test and marker-filtered invocations, the CI bucket runner, and common gotchas around the default pytest addopts and per-rank stdout interleaving. run-on-slurm covers a minimal sbatch skeleton, `MASTER_ADDR` / `MASTER_PORT` / `WORLD_SIZE` / `NODE_RANK` setup, the conditional rules for `CUDA_DEVICE_MAX_CONNECTIONS` (pre-Blackwell vs Blackwell, FSDP, `overlap_moe_expert_parallel_comm`), container conventions, `squeue`/`sacct`/`scancel`, and per-rank failure diagnosis. Both follow the existing skills/ convention: a directory per skill with a SKILL.md file and the standard frontmatter (name, description, TRIGGER when, DO NOT TRIGGER when).
yashaswikarnati
force-pushed
the
docs-skills-NMFW-451-megatron-lm-skills
branch
from
April 28, 2026 22:29
485ac83 to
31f3634
Compare
Phlip79
approved these changes
Apr 28, 2026
The existing testsystem skill covers CI pipelines, recipe YAMLs, and test-failure investigation. With the new run-unit-tests skill landing alongside it, the unqualified name "testsystem" is easy to confuse with "system for running tests." Rename to ci-test-system, which matches the actual scope, and update every cross-reference: - skills/ci-test-system/SKILL.md: name field - skills/build-and-dependency/SKILL.md: DO NOT TRIGGER cross-reference - skills/run-unit-tests/SKILL.md: DO NOT TRIGGER cross-reference - skills/run-on-slurm/SKILL.md: DO NOT TRIGGER cross-reference The body of ci-test-system/SKILL.md does not reference its own name, so no further edits inside that file.
Contributor
Author
|
/ok to test 928c14c |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25135414691 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25136313569 |
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.