Skip to content

Fix cache gating - #4455

Merged
wdykas merged 7 commits into
NVIDIA:mainfrom
wdykas:fix-mamba
Apr 27, 2026
Merged

Fix cache gating#4455
wdykas merged 7 commits into
NVIDIA:mainfrom
wdykas:fix-mamba

Conversation

@wdykas

@wdykas wdykas commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

When cleaning up the PR from yesterday before merge I accidentally broke the performance improvement. Because we can eval every step in our inference code it was switching on the rebuilding the cache every step. We have fixed this and made sure the correct tensor is recorded during cuda graph building

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@wdykas
wdykas requested review from a team as code owners April 23, 2026 23:14
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 23, 2026 23:14
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Apr 23, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 23, 2026
@wdykas

wdykas commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 6058614

Comment thread megatron/core/ssm/mamba_mixer.py
@wdykas

wdykas commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test da286c0

@wdykas

wdykas commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 972c7ad

@wdykas
wdykas marked this pull request as ready for review April 24, 2026 14:10
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 24, 2026 14:10
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Apr 24, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 24, 2026
@wdykas
wdykas enabled auto-merge April 27, 2026 17:48
@wdykas

wdykas commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 9d56ef9

@wdykas
wdykas added this pull request to the merge queue Apr 27, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25017684832

Merged via the queue into NVIDIA:main with commit ebd70d3 Apr 27, 2026
68 checks passed
@wdykas
wdykas deleted the fix-mamba branch April 27, 2026 21:07
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants