Skip to content

Reorder mtp_post_process after attn backward in 1F1B schedule plan - #4430

Merged
yaox12 merged 1 commit into
NVIDIA:devfrom
gdengk:gdeng/mtp-post-process-attn-bwd-order
Apr 23, 2026
Merged

Reorder mtp_post_process after attn backward in 1F1B schedule plan#4430
yaox12 merged 1 commit into
NVIDIA:devfrom
gdengk:gdeng/mtp-post-process-attn-bwd-order

Conversation

@gdengk

@gdengk gdengk commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Move mtp_post_process.forward out of the moe_combine fp8 context block so it runs after the attn backward, improving overlap between the forward mtp_post_process and the backward attn compute.

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Move mtp_post_process.forward out of the moe_combine fp8 context block
so it runs after the attn backward, improving overlap between the
forward mtp_post_process and the backward attn compute.
@gdengk
gdengk requested review from a team as code owners April 22, 2026 18:16
@copy-pr-bot

copy-pr-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@gdengk
gdengk requested a review from Wohox April 22, 2026 18:16

@Wohox Wohox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaox12

yaox12 commented Apr 23, 2026

Copy link
Copy Markdown
Member

/ok to test 2e7fdc3

@yaox12
yaox12 enabled auto-merge April 23, 2026 10:09
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 23, 2026
@yaox12
yaox12 added this pull request to the merge queue Apr 23, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24834590229

Merged via the queue into NVIDIA:dev with commit db5ade5 Apr 23, 2026
62 of 63 checks passed
@gdengk
gdengk deleted the gdeng/mtp-post-process-attn-bwd-order branch April 23, 2026 21:36
mmarcinkiewicz pushed a commit that referenced this pull request Apr 24, 2026
…4430)

Co-authored-by: Gao Deng <gdeng@login-lyris01.lyris.clusters.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants