Skip to content

Revert "fix mfsdp unwrap stuck at MegatronFSDP [dev] (#4273)" #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BestJuly merged 1 commit into from
Apr 21, 2026
Merged

Revert "fix mfsdp unwrap stuck at MegatronFSDP [dev] (#4273)" #4393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions megatron/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2217,12 +2217,9 @@ def unwrap_model(model, module_instances=None):
from megatron.core.distributed.fsdp.mcore_fsdp_adapter import (
FullyShardedDataParallel as megatron_FSDP,
)
from megatron.core.distributed.fsdp.src.megatron_fsdp.megatron_fsdp import (
MegatronFSDP as MegatronFSDPModule,
)
from megatron.core.transformer.module import Float16Module

module_instances = (DDP, torch_FSDP, megatron_FSDP, Float16Module, MegatronFSDPModule)
module_instances = (DDP, torch_FSDP, megatron_FSDP, Float16Module)

return_list = True
if not isinstance(model, list):
Expand Down
137 changes: 0 additions & 137 deletions tests/unit_tests/distributed/test_unwrap_model.py
View file
Open in desktop

This file was deleted.

Loading