fix(ci): wrap uv install in retry block - #4387
Merged
Merged
Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test |
svcnvidia-nemo-ci
marked this pull request as draft
April 20, 2026 09:14
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
thomasdhc
approved these changes
Apr 20, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24669855535 |
Phlip79
added a commit
to Phlip79/Megatron-LM
that referenced
this pull request
Apr 20, 2026
The rename commit (d6a3854) and subsequent merges accidentally reverted unrelated upstream changes. Restore upstream versions of: - megatron/training/arguments.py: restore 'adaptive_muon' optimizer choice and --optimizer-cuda-graph argument; remove stray --no-scatter-gather-tensors-in-pipeline - megatron/training/training.py: restore OptimizerCudaGraphWrapper import, save_checkpoint_and_time() usage, and timer logic from upstream - megatron/rl/sequence_packing_utils.py: restore removal of unused packed_attention_mask parameter (upstream NVIDIA#3859) - .github/actions/action.yml: restore retry loop around uv install (upstream NVIDIA#4387) Re-applied only the intended rename-related import path changes to arguments.py (2 lines) and training.py (2 lines). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uvinstaller curl command in a retry loop (3 attempts, 10 s sleep between attempts), consistent with the existingapt-getretry pattern above it.Motivation
The install occasionally fails due to transient network issues. Without a retry, the entire CI job fails hard on a flaky download.
Example