Fix incorrect bias display in extra_repr of Column/RowParallelLinear - #4330
Merged
Conversation
svcnvidia-nemo-ci
marked this pull request as draft
April 16, 2026 01:51
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
Contributor
Author
|
@ko3n1g Could you review this PR? This is absolutely a bug. |
svcnvidia-nemo-ci
added
waiting-on-maintainers
Contributor
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
asolergi-nv
approved these changes
Apr 27, 2026
deepakn94
approved these changes
Apr 27, 2026
ericharper
approved these changes
Apr 27, 2026
ericharper
enabled auto-merge
April 27, 2026 17:13
svcnvidia-nemo-ci
added
Approved
Contributor
|
/ok to test 0e636da |
svcnvidia-nemo-ci
removed
the
waiting-on-maintainers
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25036339897 |
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
…VIDIA#4330) Co-authored-by: mhh111 <mahonghao1@huawei.com> Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
…VIDIA#4330) Co-authored-by: mhh111 <mahonghao1@huawei.com> Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
…VIDIA#4330) Co-authored-by: mhh111 <mahonghao1@huawei.com> Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
…VIDIA#4330) Co-authored-by: mhh111 <mahonghao1@huawei.com> Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Problem
The extra_repr method in both ColumnParallelLinear and RowParallelLinear uses an incorrect condition to check bias enablement:
use_bias = self.bias is not None and self.bias is TrueSince self.bias is either a torch.nn.Parameter or None (never a boolean True), the bias field in the module print representation always shows False, even when bias is actually enabled.
Fix
Correct the bias existence check to:
use_bias = self.bias is not NoneImpact
Only fixes the string representation (print output) of tensor-parallel linear layers.
No functional change to training, inference, init, gradients, or distributed communication.
Validation
Create layer with bias=True → print shows bias=True
Create layer with bias=False → print shows bias=False
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.