Skip to content

Allow inference to asynchronously await GPU work completion - #4295

Draft
tdene wants to merge 10 commits into
NVIDIA:mainfrom
tdene:tde/exclusive_asyncio_gpu_work
Draft

Allow inference to asynchronously await GPU work completion#4295
tdene wants to merge 10 commits into
NVIDIA:mainfrom
tdene:tde/exclusive_asyncio_gpu_work

Conversation

@tdene

@tdene tdene commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot

copy-pr-bot Bot commented Apr 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tdene
tdene marked this pull request as ready for review April 14, 2026 10:53
@tdene
tdene requested review from a team as code owners April 14, 2026 10:53
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 14, 2026 10:53
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 14, 2026
@tdene
tdene force-pushed the tde/exclusive_asyncio_gpu_work branch from d83dcc6 to 4f5252d Compare April 14, 2026 11:21
@tdene
tdene marked this pull request as draft April 14, 2026 11:21
@tdene
tdene marked this pull request as ready for review April 14, 2026 11:22
@tdene tdene changed the title Allow GPU work exclusive ownership of asyncio loop Allow inference to asynchronously await GPU work completion Apr 14, 2026
@tdene
tdene marked this pull request as draft April 14, 2026 12:32
@tdene
tdene force-pushed the tde/exclusive_asyncio_gpu_work branch from c0639c4 to b8da2f3 Compare April 14, 2026 12:32
@Phlip79
Phlip79 removed the request for review from a team April 15, 2026 16:17
@tdene
tdene force-pushed the tde/exclusive_asyncio_gpu_work branch from da29329 to e1b76a1 Compare April 23, 2026 13:32
tdene added a commit to tdene/Megatron-LM that referenced this pull request Apr 27, 2026
tdene added a commit to tdene/Megatron-LM that referenced this pull request Apr 28, 2026
tdene added a commit to tdene/Megatron-LM that referenced this pull request Apr 28, 2026
tdene added a commit to tdene/Megatron-LM that referenced this pull request Apr 29, 2026
@tdene
tdene force-pushed the tde/exclusive_asyncio_gpu_work branch 2 times, most recently from 0b0f02d to ffe3734 Compare May 5, 2026 11:35
@tdene
tdene force-pushed the tde/exclusive_asyncio_gpu_work branch from ffe3734 to 8d3f778 Compare May 6, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants