[Main] Fix TE version check for retain_pinned_cpu_buffers in cpu offload - #4267
Merged
yaox12 merged 3 commits intoApr 15, 2026
Merged
Conversation
The retain_pinned_cpu_buffers parameter was added to TransformerEngine's get_cpu_offload_context in TE v2.10 (PR NVIDIA#1762), not v2.5. The previous version gate of 2.5.0 caused a TypeError for users running TE 2.5-2.9. Add an intermediate branch for TE 2.5-2.9 that passes double_buffering but not retain_pinned_cpu_buffers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
svcnvidia-nemo-ci
marked this pull request as draft
April 13, 2026 05:47
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
BestJuly
changed the title
BestJuly
marked this pull request as ready for review
April 13, 2026 05:50
yaox12
approved these changes
Apr 13, 2026
ericharper
approved these changes
Apr 14, 2026
jaredcasper
approved these changes
Apr 15, 2026
svcnvidia-nemo-ci
added
Approved
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24433494622 |
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
…oad (NVIDIA#4267) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
…oad (NVIDIA#4267) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
…oad (NVIDIA#4267) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
…oad (NVIDIA#4267) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retain_pinned_cpu_buffersparameter inget_cpu_offload_contextretain_pinned_cpu_buffersparameter was added in TE v2.10 ([PyTorch] Activation offloading refactor TransformerEngine#1762), but the version check was gating on2.5.0, causing aTypeErrorfor TE 2.5–2.9 usersdouble_bufferingbut notretain_pinned_cpu_buffers🤖 Generated with Claude Code