Skip to content

[Dev] Fix TE version check for retain_pinned_cpu_buffers in cpu offload #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BestJuly merged 1 commit into from
Apr 13, 2026
Merged

[Dev] Fix TE version check for retain_pinned_cpu_buffers in cpu offload #4266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions megatron/core/extensions/transformer_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2650,8 +2650,8 @@ def get_cpu_offload_context(
retain_pinned_cpu_buffers,
):
"""Get CPU offload context and sync function."""
if is_te_min_version("2.5.0"):
# Enables the additional double buffering switch for activations during LLM training
if is_te_min_version("2.10.0"):
# TE 2.10+ supports retain_pinned_cpu_buffers
context, sync_func = _get_cpu_offload_context(
enabled,
num_layers,
Expand All @@ -2661,6 +2661,16 @@ def get_cpu_offload_context(
double_buffering,
retain_pinned_cpu_buffers=retain_pinned_cpu_buffers,
)
elif is_te_min_version("2.5.0"):
# TE 2.5-2.9 supports double_buffering but not retain_pinned_cpu_buffers
context, sync_func = _get_cpu_offload_context(
enabled,
num_layers,
model_layers,
activation_offloading,
weight_offloading,
double_buffering,
)
elif is_te_min_version("1.10.0.dev0"):
context, sync_func = _get_cpu_offload_context(
enabled, num_layers, model_layers, activation_offloading, weight_offloading
Expand Down
Loading