Skip to content

Get device correctly when module returns a dict instead of individual tensor - #4265

Merged
shifangx merged 2 commits into
NVIDIA:mainfrom
shifangx:shifang/fix_schedule_for_multimodule
Apr 16, 2026
Merged

Get device correctly when module returns a dict instead of individual tensor#4265
shifangx merged 2 commits into
NVIDIA:mainfrom
shifangx:shifang/fix_schedule_for_multimodule

Conversation

@shifangx

@shifangx shifangx commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Issue description

When the model contains a MoE layer (or MTP layer), the device of the MoE loss scale (or MTP loss scale) needs to be set according to the device of the output tensor.
However, a problem occurs when trying to obtain the device of the output tensor for multimodule schedule.

Root cause

Normally, the forward function returns the output as a tensor.
But under the multi‑module schedule, the forward function returns the output as a dictionary, so the way we get the output device needs to be updated accordingly.

How to fix

This fix checks whether output is a dictionary. If it is, it takes the first value from the dict and gets its device.
Otherwise, it directly gets the device from output tensor.
This ensures consistent device extraction regardless of output format.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@shifangx
shifangx requested review from a team as code owners April 13, 2026 00:55
@copy-pr-bot

copy-pr-bot Bot commented Apr 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 13, 2026 00:55
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@shifangx

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Apr 13, 2026

Copy link
Copy Markdown

/ok to test

@shifangx, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@shifangx
shifangx marked this pull request as ready for review April 13, 2026 01:10
@shifangx
shifangx enabled auto-merge April 13, 2026 01:10
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 13, 2026 01:10
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Apr 14, 2026
@shifangx shifangx changed the title fix multimodule schedule for the the case that output is dict fix multimodule schedule for models with moe layers or mtp layers Apr 14, 2026
@deepakn94 deepakn94 changed the title fix multimodule schedule for models with moe layers or mtp layers Get device correctly when module returns a dict instead of individual tensor Apr 14, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 14, 2026
@Phlip79
Phlip79 removed the request for review from a team April 15, 2026 16:18
@shifangx

Copy link
Copy Markdown
Contributor Author

/ok to test 7285cf0

@shifangx

Copy link
Copy Markdown
Contributor Author

/ok to test 6217ab5

@shifangx
shifangx added this pull request to the merge queue Apr 16, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24492670798

Merged via the queue into NVIDIA:main with commit 23265d2 Apr 16, 2026
64 of 65 checks passed
@shifangx
shifangx deleted the shifang/fix_schedule_for_multimodule branch April 16, 2026 05:22
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
…al tensor (NVIDIA#4265)

Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
…al tensor (NVIDIA#4265)

Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants