Skip to content

Enabled fused grouped MLP for quick_gelu and add config for grouped params - #4219

Merged
yaox12 merged 6 commits into
NVIDIA:devfrom
ksivaman:fused_grouped_mlp_updates
Apr 9, 2026
Merged

Enabled fused grouped MLP for quick_gelu and add config for grouped params#4219
yaox12 merged 6 commits into
NVIDIA:devfrom
ksivaman:fused_grouped_mlp_updates

Conversation

@ksivaman

@ksivaman ksivaman commented Apr 8, 2026

Copy link
Copy Markdown
Member

What does this PR do ?

  • Add configurable arguments for single_grouped_weight and single_grouped_bias.
  • Enable GroupedMLP fused path via TE when activation is Quick GeGLU.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

ksivaman added 2 commits April 8, 2026 19:01
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
ksivaman requested review from a team as code owners April 8, 2026 23:28
@copy-pr-bot

copy-pr-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
return_bias=self.te_return_bias,
parallel_mode=parallel_mode,
**extra_kwargs,
single_grouped_weight=getattr(config, "moe_single_grouped_weight", False),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause an error if single_grouped_weight is not in the signature of GroupedLinear.__init__()?
A better way may be

if is_te_min_version("2.14.0"):
    extra_kwargs["single_grouped_weight"] = getattr(config, "moe_single_grouped_weight", False)
    extra_kwargs["single_grouped_bias"] = getattr(config, "moe_single_grouped_bias", False)

Then pass them via **extra_kwargs.

@yaox12

yaox12 commented Apr 9, 2026

Copy link
Copy Markdown
Member

/ok to test 86c257a

Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12

yaox12 commented Apr 9, 2026

Copy link
Copy Markdown
Member

/ok to test 06f9eab

@yaox12
yaox12 added this pull request to the merge queue Apr 9, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24178204941

Merged via the queue into NVIDIA:dev with commit 5c54484 Apr 9, 2026
62 of 63 checks passed
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 7, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 7, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 8, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 11, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 12, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 12, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 12, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 13, 2026
… params (NVIDIA#4219)

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants