Repository navigation
remove legacy tranformer and modules #4207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
53b28f3
remove legacy tranformer and modules
dimapihtar 9dc4c7b
remove legacy imports
dimapihtar 9c5e2f0
Merge branch 'main' into remove_legacy_transformer
dimapihtar 445e107
fix docs
dimapihtar 56ba238
Merge branch 'main' into remove_legacy_transformer
dimapihtar 0d4fc55
Merge branch 'main' into remove_legacy_transformer
dimapihtar 106a0be
Merge branch 'NVIDIA:main' into main
dimapihtar 422590f
Merge branch 'NVIDIA:main' into main
dimapihtar a1a6b5d
Merge branch 'main' into remove_legacy_transformer
dimapihtar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a few things that still depend on this module:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,4 @@ | ||
| # Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved. | ||
|
|
||
| from .fused_layer_norm import MixedFusedLayerNorm as LayerNorm | ||
| from .rms_norm import RMSNorm | ||
|
|
||
| from .gpt_model import GPTModel | ||
| from .language_model import get_language_model |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing
LayerNormandRMSNormalso breaks existing model files. We need to either remove the models, or merge inmainif they've already been removed.