Skip to content

Fix checkpoint inspector - #4079

Merged
janEbert merged 1 commit into
NVIDIA:mainfrom
janEbert:fix-checkpoint-inspector
Mar 31, 2026
Merged

Fix checkpoint inspector#4079
janEbert merged 1 commit into
NVIDIA:mainfrom
janEbert:fix-checkpoint-inspector

Conversation

@janEbert

Copy link
Copy Markdown
Contributor

Recent changes to dist_checkpointing.strategies were not addressed here.

Fix #4053.

Recent changes to `dist_checkpointing.strategies` were not addressed
here.
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft March 31, 2026 15:28
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Mar 31, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@janEbert
janEbert marked this pull request as ready for review March 31, 2026 15:28
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 31, 2026
@janEbert

Copy link
Copy Markdown
Contributor Author

@dimapihtar could you maybe have a look?

@dimapihtar dimapihtar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the PR!

@janEbert
janEbert enabled auto-merge March 31, 2026 15:36
@janEbert
janEbert added this pull request to the merge queue Mar 31, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23809794780

Merged via the queue into NVIDIA:main with commit ef2c8a0 Mar 31, 2026
66 of 67 checks passed
@janEbert
janEbert deleted the fix-checkpoint-inspector branch March 31, 2026 17:51
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'verify_checkpoint_and_load_strategy' from 'megatron.core.dist_checkpointing.validation'

3 participants