Repository navigation
Add QK layernorm support for dot-product attention in MambaModel #4067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
301d12e
Add QK layernorm support for dot-product attention in MambaModel
Phlip79 367b8a8
Add tests for MambaModel QK layernorm spec functions
Phlip79 1c46827
Fix linting
Phlip79 b28a11f
Fix linting again
Phlip79 97607d6
Ran isort
Phlip79 bdf2d12
Update qk layernorm settings and tests
Phlip79 488e448
Fix linting
Phlip79 e9c20a4
Fix linting again
Phlip79 d16170f
Fix TENorm isinstance check in QK layernorm test
Phlip79 2ee490b
Use blueprint system instead
Phlip79 c778f9c
Update comments and failure
Phlip79 cb2c31e
Merge branch 'main' of https://github.com/NVIDIA/Megatron-LM into phi…
Phlip79 046f443
Update ordering
Phlip79 cd26bb4
Add TODO
Phlip79 d09c4ca
Refactor QK norm resolution: explicit branches + ValueError
Phlip79 861fe3b
Merge remote-tracking branch 'origin/philip/add-qk-norm' into philip/…
Phlip79 a49723f
Update test_l2_qk_norm to set qk_l2_norm on config
Phlip79 e16a762
Set qk_l2_norm on shared test config instead of duplicating
Phlip79 236c50f
Add tests for config-driven QK norm fallback and spec/config mismatch
Phlip79 c8a313d
Fix black formatting in test_qk_layernorm_spec_config_mismatch_raises
Phlip79 1ca9061
Fix TENorm isinstance check and add L2Norm config-fallback test
Phlip79 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.