Add ability to perform local gradient accumulation in FP32 for a subset of parameters in the model - #4028
Merged
deepakn94 merged 3 commits intoMar 25, 2026
Conversation
…accumulation - Add separate copy to communication buffer before collective is launched (taking care to do this with and without overlapping enabled) - Zero out extra main_grad tensors when reset() is called - Log main_grad.dtype for every parameter for debugging - Nit: Log params in right order - [From Cursor / Claude Opus 4.5] Copy from communication buffer back to .main_grad to make sure optimizer uses reduced weights in optimizer step - Scale extra main_grad if it exists if using --calculate-per-token-loss
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
svcnvidia-nemo-ci
marked this pull request as draft
March 25, 2026 19:21
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
deepakn94
changed the title
deepakn94
marked this pull request as ready for review
March 25, 2026 19:21
Contributor
Author
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
jaredcasper
approved these changes
Mar 25, 2026
yaoyu-33
approved these changes
Mar 25, 2026
Contributor
Author
|
/ok to test ee2463f |
deepakn94
force-pushed
the
dnarayanan/local_grad_accumulation_in_fp32
branch
from
March 25, 2026 21:07
ee2463f to
1df3f83
Compare
deepakn94
enabled auto-merge
March 25, 2026 21:10
Contributor
Author
|
/ok to test 1df3f83 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23566193634 |
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
…et of parameters in the model (NVIDIA#4028) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
…et of parameters in the model (NVIDIA#4028) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
…et of parameters in the model (NVIDIA#4028) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
…et of parameters in the model (NVIDIA#4028) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.