Fix emerging optimizer init_group for ckpt loading - #3897
Merged
Conversation
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
Contributor
Author
|
/ok to test 7496370 |
ko3n1g
approved these changes
Mar 17, 2026
FDecaYed
enabled auto-merge
March 17, 2026 11:05
yaox12
approved these changes
Mar 17, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23204532924 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Mar 17, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23208145215 |
5 tasks
skyw
added a commit
to skyw/Megatron-LM
that referenced
this pull request
Apr 2, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Recent
Emerging-Optimizerschanges addedskip_non_grad_paramsto_init_group. Megatron checkpoint initialization needs to explicitly disable skipping so optimizer state is fully initialized when loading/restoring checkpoints._init_group(..., skip_non_grad_params=False)so state is created for params that do not yet have grads during checkpoint restore.emerging_optimizersdependency pin tobc634ff8c0cf4fb5dbae0a531081281b499be3a0to pick up the newskip_non_grad_paramsoption.Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.