[dev] fix no_shard training convergency and add unittest for no_shard - #3835
Merged
Conversation
wplf
changed the title
FDecaYed
previously requested changes
Mar 19, 2026
shjwudp
approved these changes
Mar 23, 2026
add unittest for no_shard and add empty cache to avoid OOM add meta_device_check for no_shard following fully_shard.py:326 Signed-off-by: jinliangl <jinliangl@nvidia.com>
wplf
force-pushed
the
jinliang/fix-fsdp-no-shard-dev
branch
from
May 21, 2026 07:11
127851a to
c4a4463
Compare
Contributor
Author
|
/ok to test c4a4463 |
Victarry
approved these changes
May 21, 2026
wplf
enabled auto-merge
May 21, 2026 07:51
cspades
approved these changes
May 21, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26494858704 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
main PR #3754